Expose thread.toJSON() on the public Thread type#235
Closed
jacehwang wants to merge 1 commit intovercel:mainfrom
Closed
Expose thread.toJSON() on the public Thread type#235jacehwang wants to merge 1 commit intovercel:mainfrom
jacehwang wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@jacehwang is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Hey @jacehwang, thanks for catching this and putting up the fix! 🙌 This has actually already been fixed on The type regression test is a nice idea though! If we wanted to add something like that, we'd probably lean toward vitest's Closing this one out since the fix is already in. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toJSON(): SerializedThreadto the publicThreadinterfaceimport type { Thread } from "chat"Problem
ThreadImplalready exposestoJSON()at runtime and the docs/examples usethread.toJSON(), but the publicThreadtype indist/index.d.tsdid not include that method. This caused consumer builds to fail with:Testing
pnpm validate